[Vmware to KVM Migration] Fix issue with vCenter Standalone hosts for VM listing by nvazquez · Pull Request #11091 · apache/cloudstack

nvazquez · 2025-06-26T02:59:47Z

Description

This PR fixes the listing of VMware VMs for Migration to KVM on vCenter datacenters that have standalone hosts (don't belong to any cluster)

Example setup with standalone hosts:

Listing retrieved successfully, setting cluster field empty on the listing table:

Fixes: #11090

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Set standalone hosts on the datacenter, having VMs on them
List VMs for Migration on CloudStack pointing to the vCenter

How did you try to break this feature and the system with this change?

… VM listing

nvazquez · 2025-06-26T03:00:51Z

@blueorangutan package

blueorangutan · 2025-06-26T03:02:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-06-26T03:07:34Z

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.18%. Comparing base (cbd2b5a) to head (3af1702).
Report is 3 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/hypervisor/vmware/mo/BaseMO.java	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11091   +/-   ##
=========================================
  Coverage     15.17%   15.18%           
- Complexity    11363    11365    +2     
=========================================
  Files          5416     5416           
  Lines        475911   475919    +8     
  Branches      58096    58095    -1     
=========================================
+ Hits          72241    72251   +10     
+ Misses       395584   395582    -2     
  Partials       8086     8086

Flag	Coverage Δ
uitests	`4.28% <ø> (ø)`
unittests	`15.90% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-06-26T04:09:09Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13921

DaanHoogland · 2025-06-26T07:04:21Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-06-26T07:06:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

DaanHoogland · 2025-06-26T07:09:14Z

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/BaseMO.java

+            String msg = String.format("Standalone host %s found, setting empty cluster field", hostName);
+            s_logger.debug(msg);


Suggested change

String msg = String.format("Standalone host %s found, setting empty cluster field", hostName);

s_logger.debug(msg);

String msg = String.format(“Host %s not found, assuming standalone host, setting cluster name as empty", hostName);

s_logger.info(msg);

Hi @DaanHoogland the host is found, but not its cluster. Let me rephrase it a bit

weizhouapache

code lgtm

sureshanaparti

code lgtm

nvazquez · 2025-07-07T11:00:40Z

@blueorangutan package

blueorangutan · 2025-07-07T11:02:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm

blueorangutan · 2025-07-07T12:28:40Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14067

sureshanaparti · 2025-07-08T06:37:54Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2025-07-08T06:40:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2025-07-08T21:12:16Z

[SF] Trillian test result (tid-13711)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50116 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11091-t13711-vmware-70u3.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

kiranchavala

LGTM, Manually Tested with Vcenter datacenter having single exi host

Was able to import the vm successfully to kvm

… VM listing (apache#11091)

[Vmware to KVM Migration] Fix issue with vCenter Standalone hosts for…

eb7447e

… VM listing

boring-cyborg bot added the component:vmware label Jun 26, 2025

nvazquez requested review from DaanHoogland, Pearl1594, harikrishna-patnala, kiranchavala, shwstppr, sureshanaparti and weizhouapache June 26, 2025 03:00

nvazquez added type:bug component:kvm component:migration labels Jun 26, 2025

nvazquez linked an issue Jun 26, 2025 that may be closed by this pull request

[Vmware to KVM Migration] Standalone hosts are not supported for listing VMs on vCenter #11090

Closed

DaanHoogland reviewed Jun 26, 2025

View reviewed changes

weizhouapache approved these changes Jun 26, 2025

View reviewed changes

DaanHoogland added this to the 4.19.4 milestone Jul 2, 2025

DaanHoogland added the status:needs-testing label Jul 2, 2025

sureshanaparti approved these changes Jul 4, 2025

View reviewed changes

Fix logged message

3af1702

DaanHoogland approved these changes Jul 7, 2025

View reviewed changes

kiranchavala approved these changes Jul 9, 2025

View reviewed changes

kiranchavala removed the status:needs-testing label Jul 9, 2025

DaanHoogland merged commit c782835 into apache:4.19 Jul 9, 2025
25 of 26 checks passed

DaanHoogland deleted the 4193-vmware-fix-standalone-hosts branch July 9, 2025 07:41

DaanHoogland mentioned this pull request Jul 9, 2025

[Vmware to KVM Migration] Standalone hosts are not supported for listing VMs on vCenter #11090

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025

[Vmware to KVM Migration] Fix issue with vCenter Standalone hosts for…

5bd8b49

… VM listing (apache#11091)

		String msg = String.format("Standalone host %s found, setting empty cluster field", hostName);
		s_logger.debug(msg);

Conversation

nvazquez commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Jun 26, 2025

Uh oh!

blueorangutan commented Jun 26, 2025

Uh oh!

codecov bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jun 26, 2025

Uh oh!

DaanHoogland commented Jun 26, 2025

Uh oh!

blueorangutan commented Jun 26, 2025

Uh oh!

DaanHoogland Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nvazquez Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jul 7, 2025

Uh oh!

blueorangutan commented Jul 7, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 7, 2025

Uh oh!

sureshanaparti commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nvazquez commented Jun 26, 2025 •

edited

Loading

codecov bot commented Jun 26, 2025 •

edited

Loading

DaanHoogland Jun 26, 2025 •

edited

Loading

nvazquez Jul 7, 2025 •

edited

Loading